test: always use package manager force option in version add command E2E#26720
Merged
clydin merged 1 commit intoangular:16.2.xfrom Dec 20, 2023
Merged
test: always use package manager force option in version add command E2E#26720clydin merged 1 commit intoangular:16.2.xfrom
clydin merged 1 commit intoangular:16.2.xfrom
Conversation
clydin
force-pushed
the
e2e/test-add-force
branch
from
2ce1235 to
2c42e67
Compare
The goal of the `commands/add/version-specifier` test is to check the behavior of the `ng add` command itself and not that of the package manager. To do so requires adding a package using a variety of different version specifiers. Some of which a package manager may consider incompatible with the hosting project. However, this is not relevant to the selection logic of the `ng add` command which should select the version as designed. To verify it does so within the Angular CLI, the installed version needs to be checked. As a result the package manager must install the package.
clydin
force-pushed
the
e2e/test-add-force
branch
from
2c42e67 to
e48bb0f
Compare
clydin
added
the
target: lts
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of the
commands/add/version-specifiertest is to check the behavior of theng addcommand itself and not that of the package manager. To do so requires adding a package using a variety of different version specifiers. Some of which a package manager may consider incompatible with the hosting project. However, this is not relevant to the selection logic of theng addcommand which should select the version as designed. To verify it does so within the Angular CLI, the installed version needs to be checked. As a result the package manager must install the package.